mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 56195: Updated containerizer->launch path to close IOSwitchboard FDs on error.
Date Thu, 02 Feb 2017 05:29:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56195/
-----------------------------------------------------------

(Updated Feb. 2, 2017, 5:29 a.m.)


Review request for mesos, Alexander Rukletsov, Gastón Kleiman, Gilbert Song, and Jie Yu.


Changes
-------

Updated to account for the fact that `container->launchInfos` is a `Future<list>`
and not just a `list`. Also filled in the test section.


Bugs: MESOS-7050
    https://issues.apache.org/jira/browse/MESOS-7050


Repository: mesos


Description
-------

Previously, if the containizer launch path failed before actually
launching the container, the FDs allocated to the container by the
IOSwitchboard isolator would be leaked. This would lead to deadlock in
the destroy path because the IOSwitchboard does not shutdown until the
FDs it allocates to the container have been closed. Since the
switchboard doesn't shutdown, the future returned by its 'cleanup()'
function is never satisfied.

This commit makes sure to close the FDs under all failure cases in the
launch path.


Diffs (updated)
-----

  src/slave/containerizer/mesos/containerizer.cpp 4f0a773676da45fa40ad1ad9cdfab2a19249247d


Diff: https://reviews.apache.org/r/56195/diff/


Testing (updated)
-------

Linux CentOS 7:
```
GTEST_FILTER="" make -j check
src/mesos-tests
[----------] Global test environment tear-down
[==========] 1477 tests from 167 test cases ran. (390804 ms total)
[  PASSED  ] 1477 tests.
```

Mac OS X (El Capitan)
```
GTEST_FILTER="" make -j check
src/mesos-tests
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] ExamplesTest.V1JavaFramework
[  FAILED  ] ExamplesTest.PythonFramework
```


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message