mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 56195: Updated containerizer->launch path to close IOSwitchboard FDs on error.
Date Thu, 02 Feb 2017 01:29:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56195/
-----------------------------------------------------------

(Updated Feb. 2, 2017, 1:29 a.m.)


Review request for mesos, Alexander Rukletsov, Gastón Kleiman, Gilbert Song, and Jie Yu.


Changes
-------

Protect calls to access `launchInfo` with a check for `launchInfo.isSome()`.


Bugs: MESOS-7050
    https://issues.apache.org/jira/browse/MESOS-7050


Repository: mesos


Description
-------

Previously, if the containizer launch path failed before actually
launching the container, the FDs allocated to the container by the
IOSwitchboard isolator would be leaked. This would lead to deadlock in
the destroy path because the IOSwitchboard does not shutdown until the
FDs it allocates to the container have been closed. Since the
switchboard doesn't shutdown, the future returned by its 'cleanup()'
function is never satisfied.

This commit makes sure to close the FDs under all failure cases in the
launch path.


Diffs (updated)
-----

  src/slave/containerizer/mesos/containerizer.cpp 4f0a773676da45fa40ad1ad9cdfab2a19249247d


Diff: https://reviews.apache.org/r/56195/diff/


Testing
-------

Tests still pending. WIll update when complete.


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message