mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 54712: Use the stout ELF parser to implement ldd.
Date Thu, 02 Feb 2017 00:15:49 GMT


> On Feb. 2, 2017, 12:04 a.m., Jiang Yan Xu wrote:
> > src/linux/ldd.hpp, line 30
> > <https://reviews.apache.org/r/54712/diff/2/?file=1589105#file1589105line30>
> >
> >     Sorry it only occured to me after the review but can we remove the given `path`
from the result set to match `ldd` semantics?
> >     
> >     Yes this method was originally not `ldd` and it doesn't have to be. But for
something that's "pretty much" ldd, if we implement it as `ldd` and call it `ldd`, it's much
easier for people to understand, right?
> >     
> >     :)

Done.


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54712/#review163904
-----------------------------------------------------------


On Feb. 2, 2017, 12:15 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54712/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2017, 12:15 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Kevin Klues, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6588
>     https://issues.apache.org/jira/browse/MESOS-6588
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Use the stout ELF parser to implement an ldd() API that recursively
> gathers the link dependencies of a given program.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 09ef1aee680c6b91476092dbf61d4ca3a8d256bb 
>   src/Makefile.am 6c9be54fe0ce3faaa26e2f090773d1b77bb6e430 
>   src/linux/ldd.hpp PRE-CREATION 
>   src/linux/ldd.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54712/diff/
> 
> 
> Testing
> -------
> 
> sudo make check (Fedora 25)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message