mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <>
Subject Review Request 56195: Updated containerizer->launch path to close IOSwitchboard FDs on error.
Date Thu, 02 Feb 2017 00:04:02 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos, Alexander Rukletsov, Gastón Kleiman, Gilbert Song, and Jie Yu.

Repository: mesos


Previously, if the containizer launch path failed before actually
launching the container, the FDs allocated to the container by the
IOSwitchboard isolator would be leaked. This would lead to deadlock in
the destroy path because the IOSwitchboard does not shutdown until the
FDs it allocates to the container have been closed. Since the
switchboard doesn't shutdown, the future returned by its 'cleanup()'
function is never satisfied.

This commit makes sure to close the FDs under all failure cases in the
launch path.


  src/slave/containerizer/mesos/containerizer.cpp 4f0a773676da45fa40ad1ad9cdfab2a19249247d



Tests still pending. WIll update when complete.


Kevin Klues

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message