mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 56004: Fixed MULTI_ROLE related bugs when updating framework info.
Date Wed, 01 Feb 2017 23:38:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56004/#review163900
-----------------------------------------------------------


Ship it!




Thanks for catching these issues!


src/master/master.hpp (lines 2431 - 2440)
<https://reviews.apache.org/r/56004/#comment235411>

    Could we just follow this pattern?
    
    ```cpp
    if (source.has_role()) {
      info.set_role(source.role());
    } else {
      info.clear_role();
    }
    
    if (source.roles_size() > 0) {
      info.mutable_roles()->CopyFrom(source.roles());
    } else {
      info.clear_roles();
    }
    ```


- Michael Park


On Jan. 26, 2017, 4:30 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56004/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2017, 4:30 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The first issue is that we need to update the capabilities member
> to reflect the new capabilities.
> 
> The second issue is that when we allow an upgrade or downgrade
> to or from MULTI_ROLE, we need to update the `role` and `roles`
> fields of `FrameworkInfo`.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 7e38af41ca16241dbbe3bc2e80c0848e82762a45 
> 
> Diff: https://reviews.apache.org/r/56004/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message