mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 54215: Fixed duplicate image layer ids returned by docker store.
Date Fri, 27 Jan 2017 16:43:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54215/#review163283
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp (lines 293 - 296)
<https://reviews.apache.org/r/54215/#comment234717>

    This comment here is not quite descripative. I'd suggest use the reply you wrote to me
in the review board.
    
    ALso, make sure to paste the link to docker code.



src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp (line 301)
<https://reviews.apache.org/r/54215/#comment234718>

    I'd add some comment about the order of `fslayers` here. whether it is:
    ```
    [parent, child]
    ```
    or
    ```
    [child, parent]
    ```
    
    Since child layer can overwrite contents in the parent layer, I think what backend expects
is `[parent, child]`.
    
    That means fslayers here is in `[child, parent]` order. Now, can you verify that the overwriting
is ok. I'd improve the comment here.


- Jie Yu


On Jan. 26, 2017, 1:37 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54215/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2017, 1:37 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Artem Harutyunyan, Jie Yu, Qian Zhang, and
Zhitao Li.
> 
> 
> Bugs: MESOS-6654
>     https://issues.apache.org/jira/browse/MESOS-6654
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This issue is exposed by pulling the 'mesosphere/inky' docker
> image using registry puller. Due to the duplicate layer id
> from the manifest, there are duplicate layer pathes passed
> to the backend. The aufs backend cannot handle this case and
> returns 'invalid arguments' error. Ideally, we should make
> sure that layer paths that are passed to the backend are
> unique.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp cecf34a23329a64fdbce7de4b83827a30975e9a4

> 
> Diff: https://reviews.apache.org/r/54215/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> Tested by the unit test `ROOT_CURL_INTERNET_DockerDefaultEntryptRegistryPuller`.
> 
> Manually tested using the `mesosphere/inky` image, which contains duplicate layer ids.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message