mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 53998: Fixed hook to allow for executor environment modifications.
Date Wed, 25 Jan 2017 20:11:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53998/#review163010
-----------------------------------------------------------



Bad patch!

Reviews applied: [53998]

Failed command: python support/apply-reviews.py -n -r 53998

Error:
2017-01-25 20:11:51 URL:https://reviews.apache.org/r/53998/diff/raw/ [1544/1544] -> "53998.patch"
[1]
error: patch failed: src/slave/containerizer/docker.cpp:1133
error: src/slave/containerizer/docker.cpp: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/16852/console

- Mesos Reviewbot


On Nov. 22, 2016, 8:26 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53998/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2016, 8:26 p.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, Kapil Arya, and Joseph Wu.
> 
> 
> Bugs: MESOS-6396
>     https://issues.apache.org/jira/browse/MESOS-6396
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When being used on a task run by a command executor, the hook
> `slavePreLaunchDockerEnvironmentDecorator` did not allow for extending
> the executor's own environment but only the environment of the task.
> By using the hook returned environment for the executor in any case
> and supplying a task specific environment for the command executor,
> that limitation is fixed.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c 
> 
> Diff: https://reviews.apache.org/r/53998/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> * WIP - functional testing pending - WIP *
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message