mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <>
Subject Review Request 55954: Changed 'Environment.Variable.Value' from required to optional.
Date Wed, 25 Jan 2017 20:10:31 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos, Jan Schlicht and Vinod Kone.

Bugs: MESOS-6991

Repository: mesos


To prepare for future work which will enable the
modular fetching of secrets, we should change the
Environment.Variable.Value field from required to
optional. This way, the field can be left empty
and filled in by a secret fetching module.


  include/mesos/mesos.proto 8f14444d6957a97eff1e0a94817d38e7a7de6d69 
  include/mesos/v1/mesos.proto 74e7851b147ab821dceeab6e838d34b092f101c3 
  src/common/validation.hpp fee955139d9699caa651d9bbd03342f2eba8143f 
  src/common/validation.cpp b2548ad87b4227d6e498c49b5694acb362f6281b 
  src/health-check/health_checker.cpp a8424b75927d15dc1b897faf0e47cf075c70ff26 
  src/master/validation.cpp 5f134b781901f2de6a90fa6a10d42cc7629c27a0 



Testing information at the end of this review chain.


Greg Mann

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message