mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 55911: Fixed flakiness in TaskValidationTest.TaskReusesUnreachableTaskID.
Date Wed, 25 Jan 2017 19:51:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55911/
-----------------------------------------------------------

(Updated Jan. 25, 2017, 7:51 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Improve commit description.


Bugs: MESOS-6983
    https://issues.apache.org/jira/browse/MESOS-6983


Repository: mesos


Description (updated)
-------

The previous coding of the test partitioned one agent and then launched
a second agent. However, when run as root, the second agent discovered
(via global cgroups) the task that was started by the first agent, which
it then proceeded to kill.

To avoid this, we now shutdown the first agent after partitioning it and
before starting the second agent.


Diffs (updated)
-----

  src/tests/master_validation_tests.cpp 914b3c5749f775cce806f37c26e67d1f0f5351c6 

Diff: https://reviews.apache.org/r/55911/diff/


Testing
-------

`make check`

Without this change, this test fails on most platforms in the internal CI. With this change,
no failures of this test are observed.


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message