mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Review Request 55863: Introduce a helper for injecting AllocationInfo into offer operations.
Date Mon, 23 Jan 2017 22:59:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55863/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier, Jay Guo, Guangya Liu, and Michael Park.


Bugs: MESOS-6967
    https://issues.apache.org/jira/browse/MESOS-6967


Repository: mesos


Description
-------

Previously, `Resource` did not contain `AllocationInfo`. So for
backwards compatibility with old schedulers and tooling, we must
allow operations to contain `Resource`s without an `AllocationInfo`.

This introduces a function which allows the master to inject the
offer's `AllocationInfo` into the operation's resources.


Diffs
-----

  src/common/protobuf_utils.hpp faa7e2a759fd2b1ce5def662679f573ec6fefd28 
  src/common/protobuf_utils.cpp dd20759affe3adf2867a33bf875c9ee82862038d 
  src/tests/protobuf_utils_tests.cpp bc2a3d0ebe544a58d0de8f2f7174c170113ddf2e 

Diff: https://reviews.apache.org/r/55863/diff/


Testing
-------

Added a test.


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message