mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 55491: Added a `support/README.md` and the `support/jenkins` directory.
Date Wed, 18 Jan 2017 19:38:04 GMT


> On Jan. 18, 2017, 4:50 a.m., Benjamin Bannier wrote:
> > support/jenkins/reviewbot.sh, line 32
> > <https://reviews.apache.org/r/55491/diff/5/?file=1607400#file1607400line32>
> >
> >     Hardcoding a password here seems like a pretty bad idea. Could we instead pass
it in from the outside, e.g., via an environment variable?
> >     
> >     We very likely also need to soon change this password now since it is known
to everybody.

I've figured out how to hide the password. I'll change the password shortly as well.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55491/#review162080
-----------------------------------------------------------


On Jan. 18, 2017, 8:38 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55491/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2017, 8:38 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   support/README.md PRE-CREATION 
>   support/jenkins/README.md PRE-CREATION 
>   support/jenkins/buildbot.sh PRE-CREATION 
>   support/jenkins/reviewbot.sh PRE-CREATION 
>   support/jenkins/tidybot.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/55491/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message