mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <>
Subject Re: Review Request 55621: Fixed issues with the Docker fetcher when using a proxy.
Date Wed, 18 Jan 2017 13:45:16 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 18, 2017, 2:45 p.m.)

Review request for mesos, Benjamin Bannier, Gilbert Song, and Jie Yu.


Addressed issues, added more checks for CONNECT response.

Bugs: MESOS-6010

Repository: mesos


When behing a proxy, 'curl' uses HTTP CONNECT tunneling to access
HTTPS. This lead to problems with our HTTP parser because the response
of a 'CONNECT' doesn't have neither headers nor a body.

Diffs (updated)

  src/uri/fetchers/docker.cpp 027e7480bd91038b2e51031dc77aad779d6d5a88 



./bin/ without a proxy (to test that it's not breaking existing behavior)
./bin/ behind a proxy.
For example by running:
docker run -d -p 3128:3128 minumum2scp/squid
export https_proxy=
Without this diff, tests cases in the `DockerFetcherPluginTest` fixture should fail.


Jan Schlicht

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message