mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 55621: Fixed issues with the Docker fetcher when using a proxy.
Date Wed, 18 Jan 2017 13:34:50 GMT


> On Jan. 17, 2017, 7:11 p.m., Jie Yu wrote:
> > src/uri/fetchers/docker.cpp, line 171
> > <https://reviews.apache.org/r/55621/diff/1/?file=1606547#file1606547line171>
> >
> >     I think we need a case insensitive os::getenv because one can use `HTTPS_PROXY`
as well.
> >     
> >     Maybe introduce a default parameter `Option<bool> caseSensitive` in os::getenv,
default to None(). None() means use system default.
> >     
> >     If you feel the above is too much for now, add a helper to do that for now in
this file and add a TODO.

Making `os::getenv` case insensitive wouldn't do the trick, as they aren't case insensitive
in Linux and both the lower-case as well as the upper-case variable could be defined. For
curl the lower case version has precedence (see https://curl.haxx.se/docs/manpage.html in
the 'Environment' section), but this may not be the general case.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55621/#review161893
-----------------------------------------------------------


On Jan. 17, 2017, 3:53 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55621/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2017, 3:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-6010
>     https://issues.apache.org/jira/browse/MESOS-6010
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When behing a proxy, 'curl' uses HTTP CONNECT tunneling to access
> HTTPS. This lead to problems with our HTTP parser because the response
> of a 'CONNECT' doesn't have neither headers nor a body.
> 
> 
> Diffs
> -----
> 
>   src/uri/fetchers/docker.cpp 3f38dddfb4c089322fe4e13b1ef2070b4835885c 
> 
> Diff: https://reviews.apache.org/r/55621/diff/
> 
> 
> Testing
> -------
> 
> ./bin/mesos-test.sh without a proxy (to test that it's not breaking existing behavior)
> ./bin/mesos-tests.sh behind a proxy.
> For example by running:
> ```
> docker run -d -p 3128:3128 minumum2scp/squid
> export https_proxy=127.0.0.1:3128
> ./bin/mesos-tests.sh
> ```
> Without this diff, tests cases in the `DockerFetcherPluginTest` fixture should fail.
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message