mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 55490: Used the `mesos/mesos-tidy` image from DockerHub.
Date Wed, 18 Jan 2017 12:53:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55490/#review162068
-----------------------------------------------------------




support/mesos-tidy.sh (line 22)
<https://reviews.apache.org/r/55490/#comment233317>

    Let's keep this further down so to not take away from `CHECKS` prominence. Any reason
we'd want to deviate from `MESOS_DIRECTORY` used elsewhere? They seem to mean the same thing
(extracted in slightly different ways).


- Benjamin Bannier


On Jan. 18, 2017, 9:58 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55490/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2017, 9:58 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used the `mesos/mesos-tidy` image from DockerHub.
> 
> 
> Diffs
> -----
> 
>   support/mesos-tidy.sh 96d3ecb91f5476ff499ca5f043c527681c30efe9 
> 
> Diff: https://reviews.apache.org/r/55490/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message