mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 55571: Changed Master::Framework::updateFrameworkInfo so it can return errors.
Date Tue, 17 Jan 2017 17:13:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55571/
-----------------------------------------------------------

(Updated Jan. 17, 2017, 6:13 p.m.)


Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu.


Changes
-------

Comment from guoger: Allow Master::activateRecoveredFramework to fail.


Bugs: MESOS-6631
    https://issues.apache.org/jira/browse/MESOS-6631


Repository: mesos


Description
-------

This allows us to confirm that an updated FrameworkInfo is fully
compatible with an already known one. By performing this check in
updateFrameworkInfo when can be sure that both the new and old
FrameworkInfo are available (e.g., after framework reregistration, or
master or framework failover).


Diffs (updated)
-----

  src/master/master.hpp 44f4fecb1fbe8bebf830990a59a5462338e6e004 
  src/master/master.cpp b863ff6e93931c3d1ee056248084c7f44caf2fd9 

Diff: https://reviews.apache.org/r/55571/diff/


Testing
-------

Tested as part of https://reviews.apache.org/r/55271/.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message