mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Review Request 55028: Propagate `os::killtree` error correctly in `PosixLauncher::destroy`.
Date Sun, 25 Dec 2016 05:38:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55028/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, and Joseph Wu.


Repository: mesos


Description
-------

Currently if the POSIX launcher fails to kill a process group with
`os::killtree`, it will simply ignore the error. This currently causes
some executor tests to hang indefinitely on Windows, with no mention of
the true error, since `killtree` is not yet completely bug free
(MESOS-6839).

This commit will cause us to correctly propagate and report the error
when it is observed.


Diffs
-----

  src/slave/containerizer/mesos/launcher.cpp a6a8c01cb39f35f8174fcb5af0ef18de2da5ee78 

Diff: https://reviews.apache.org/r/55028/diff/


Testing
-------


Thanks,

Alex Clemmer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message