mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 55006: CMake: renamed test binaries to match autotools.
Date Fri, 23 Dec 2016 02:22:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55006/
-----------------------------------------------------------

(Updated Dec. 22, 2016, 6:22 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Changes
-------

Almost missed the Windows changes.


Repository: mesos


Description (updated)
-------

Currently CMake generates test binaries named `stout_tests`,
`process_tests` (underscores), and `mesos-tests` (dash).

We should simply follow the naming from autotools and call them
`stout-tests`, `libprocess-tests`, and `mesos-tests`.


Diffs (updated)
-----

  src/tests/CMakeLists.txt b034f1b88337b003d01450eadd262b9bc763545c 
  support/windows-build.bat 4d1d8cd6cdcf6acac259b570387923fe385f4790 

Diff: https://reviews.apache.org/r/55006/diff/


Testing (updated)
-------

`cmake --build . -- -j 6`
```
$ find . -name "*[-_]tests"
./3rdparty/libprocess/src/tests/libprocess-tests
./3rdparty/stout/tests/stout-tests
./src/mesos-tests
```

Built on Windows via `support/windows-build.bat`.


Thanks,

Michael Park


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message