mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 54880: Added unit-test for dynamic addition/deletion of CNI config.
Date Thu, 22 Dec 2016 01:50:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54880/#review159874
-----------------------------------------------------------


Fix it, then Ship it!




This test takes a long time to finish. Mainly because the filters are not set properly, as
well as the clocks are not advanced properly. I did quite a few changes while committing.
Please take a look.


src/tests/containerizer/cni_isolator_tests.cpp (line 702)
<https://reviews.apache.org/r/54880/#comment230931>

    Remove the extra space


- Jie Yu


On Dec. 20, 2016, 10:36 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54880/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2016, 10:36 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-6567
>     https://issues.apache.org/jira/browse/MESOS-6567
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added unit-test for dynamic addition/deletion of CNI config.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cni_isolator_tests.cpp 0380f2ca122c7b8ab1dac351b14f546526580e72

> 
> Diff: https://reviews.apache.org/r/54880/diff/
> 
> 
> Testing
> -------
> 
> sudo ./bin/mesos-tests.sh --gtest_filter=*Cni*
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message