mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Review Request 54928: Added initial random delay to agent (re)registration.
Date Wed, 21 Dec 2016 03:16:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54928/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, and Joseph Wu.


Bugs: MESOS-6803
    https://issues.apache.org/jira/browse/MESOS-6803


Repository: mesos


Description
-------

Currently when a master fails over, agents that do not use
authentication will choose a random time to re-register to avoid the
"thundering herd" problem. This is not true of the authenticated
codepath -- agents that have a credential will attempt to re-register
immediately.

This issue adds a random delay to the initial authentication to match
the non-authenticated code path.

This issue caps off a chain of reviews that fixes tests to work with
this change. This issue also resolves MESOS-6803.


Diffs
-----

  src/slave/slave.cpp a7a3a394e5e4b7f40a051663cd70add3890bdf18 

Diff: https://reviews.apache.org/r/54928/diff/


Testing
-------

`make check` on Unix and I ran the test suite 1000 times overnight, minus the few flaky tests.


Thanks,

Alex Clemmer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message