mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 54913: Added some missing log statements for scheduler calls.
Date Tue, 20 Dec 2016 23:09:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54913/
-----------------------------------------------------------

(Updated Dec. 20, 2016, 11:09 p.m.)


Review request for mesos and Joris Van Remoortere.


Changes
-------

Review comments, NNFR


Repository: mesos


Description (updated)
-------

Some Scheduler API calls ('KILL'/'SHUTDOWN') were missing info
level logging statements. In the case of `KILL', the logging
statement was there but was invoked in `killTask()` but was
not consistent with how we were logging for the other calls
in the continuation helper.


Diffs (updated)
-----

  src/master/master.cpp b664550d57ef9805bd23ea35ca7f9cd8f4b1ab78 

Diff: https://reviews.apache.org/r/54913/diff/


Testing
-------

make check


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message