mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 54889: Handled all possible offers in test.
Date Tue, 20 Dec 2016 22:15:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54889/
-----------------------------------------------------------

(Updated Dec. 20, 2016, 11:15 p.m.)


Review request for mesos, Alexander Rukletsov and Neil Conway.


Bugs: MESOS-6820
    https://issues.apache.org/jira/browse/MESOS-6820


Repository: mesos


Description (updated)
-------

The test FaultToleranceTest.FrameworkReregister observes a single
offer in order to monitor progress and as a trigger to initiate other
actions later in the test. The change installs expectations for
possible additional offers. This allows for the thread running the
test body to be delayed with respect to the master thread which could
in the meantime make additional offers.


Diffs
-----

  src/tests/fault_tolerance_tests.cpp 05937a917a2c175aa53b52488febb7cfd8400a13 

Diff: https://reviews.apache.org/r/54889/diff/


Testing
-------

`make check` (OS X, clang-trunk, w/ optimizations, SSL)

Before this fix `FaultToleranceTest.FrameworkReregister` failed for me multiple times in ~10k
iterations; after this patch it didn't fail in a single run I stopped after 170k iterations.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message