mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 54913: Added some missing log statements for scheduler calls.
Date Tue, 20 Dec 2016 21:59:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54913/#review159756
-----------------------------------------------------------


Fix it, then Ship it!





src/master/master.cpp (line 4697)
<https://reviews.apache.org/r/54913/#comment230805>

    You can stream the `taskId` from above.
    Please double check on the single quotes.



src/master/master.cpp (line 5947)
<https://reviews.apache.org/r/54913/#comment230806>

    Please double check the quotes here as well.


- Joris Van Remoortere


On Dec. 20, 2016, 9:40 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54913/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2016, 9:40 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Some Scheduler API calls ('KILL'/'SHUTDOWN') were missing info
> level logging statements. In the case of `KILL', the logging
> statement was there but was invoked in `killTask()` that is
> no longer used by the scheduler driver.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp b664550d57ef9805bd23ea35ca7f9cd8f4b1ab78 
> 
> Diff: https://reviews.apache.org/r/54913/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message