mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 53715: Define docker `--entrypoint` for `Windows`.
Date Tue, 20 Dec 2016 21:53:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53715/#review159671
-----------------------------------------------------------




3rdparty/stout/include/stout/os/posix/shell.hpp (lines 41 - 42)
<https://reviews.apache.org/r/53715/#comment230690>

    The motivation behind this variable is to re-use this variable for Docker.  However, it
is worthwhile to note that `/bin/sh` is *not* the canonical path for the shell.
    
    See: http://pubs.opengroup.org/onlinepubs/009695399/utilities/sh.html
    > Applications should note that the standard PATH to the shell cannot be assumed to
be either /bin/sh or /usr/bin/sh, and should be determined by interrogation of the PATH returned
by getconf PATH , ensuring that the returned pathname is an absolute pathname and not a shell
built-in.
    
    Docker containers generally hardcode the `/bin/sh` for a variety of reasons (like having
an inconsistent/incorrect `PATH` inside the container).  `/bin/sh` appears to be the canonical
default for docker, but this is liable to change according to docker's whims.
    
    Instead of defining this constant in Stout, we should just define it in the docker containerizer.
 That way, in case they make a breaking API change later on, this won't change the existing
(correct) way of shelling out.


- Joseph Wu


On Nov. 22, 2016, 10:59 p.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53715/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2016, 10:59 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and
Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Define docker `--entrypoint` for `Windows`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/posix/shell.hpp 70a9184e85ba322f1cd4ce5d12b963cd4b3ad500

>   3rdparty/stout/include/stout/os/windows/shell.hpp 17e3d564564abebf1d558b7a7a277aef3c87e5ae

> 
> Diff: https://reviews.apache.org/r/53715/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message