mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 54896: Fixed copy-template-and-create-symlink make target.
Date Tue, 20 Dec 2016 20:08:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54896/#review159743
-----------------------------------------------------------




src/Makefile.am (line 2428)
<https://reviews.apache.org/r/54896/#comment230771>

    Should this be a symlink too? Making a copy creates the possibility that you could add
environment variables in one file but not the other?


- James Peach


On Dec. 20, 2016, 1:53 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54896/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2016, 1:53 p.m.)
> 
> 
> Review request for mesos, James Peach and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This target was `PHONY`, but not declared as such. It also explicitly
> used `ln` with a `--force` flag instead of the more generally
> applicable and suggested `$(LN_S)` we use elsewhere.
> 
> This change fixes above issues. We also use independent shell commands
> for independent commands and fix some whitespace issues.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 0f62ec70816e8b48e19d35036285656a6e7cd02b 
> 
> Diff: https://reviews.apache.org/r/54896/diff/
> 
> 
> Testing
> -------
> 
> `make distcheck` (Fedora 25)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message