mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 54035: Extended test coverage of posix/rlimits isolator.
Date Tue, 20 Dec 2016 19:29:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54035/#review159658
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/containerizer/posix_rlimits_isolator_tests.cpp (line 282)
<https://reviews.apache.org/r/54035/#comment230675>

    i'll stick to slave for now given all the rest of the funciton names uses Slave (and 'slave')
still.


- Jie Yu


On Dec. 19, 2016, 11:07 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54035/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2016, 11:07 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Till Toenshoff.
> 
> 
> Bugs: MESOS-6402
>     https://issues.apache.org/jira/browse/MESOS-6402
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change adds additional tests of the posix/rlimits isolator.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/posix_rlimits_isolator_tests.cpp 24b19d9eb1cc3e19f8325fbd76182837a5690581

> 
> Diff: https://reviews.apache.org/r/54035/diff/
> 
> 
> Testing
> -------
> 
> `make check` (OS X, clang trunk w/o optimizations)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message