mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 54875: CMake: Fixed typo `-DHAS_AUTHENTICATION=0` instructions.
Date Mon, 19 Dec 2016 22:51:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54875/#review159664
-----------------------------------------------------------


Ship it!




Ship It!

- Alex Clemmer


On Dec. 19, 2016, 10:12 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54875/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2016, 10:12 p.m.)
> 
> 
> Review request for mesos and Alex Clemmer.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows builds without this flag instruct you to add it,
> but the instructions were missing the prefix `D` for define,
> and so as-is resulted in an error message.
> This could be a source of frustration for those who
> do not know CMake.
> 
> 
> Diffs
> -----
> 
>   cmake/CompilationConfigure.cmake d8575873eb315f812ba281564c42d848915349de 
> 
> Diff: https://reviews.apache.org/r/54875/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message