mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 54840: Used process::loop to avoid stack overflow due to recursion.
Date Mon, 19 Dec 2016 18:27:19 GMT


> On Dec. 19, 2016, 5:06 p.m., Jie Yu wrote:
> > 3rdparty/libprocess/src/http.cpp, line 1399
> > <https://reviews.apache.org/r/54840/diff/2/?file=1588559#file1588559line1399>
> >
> >     shared_ptr<size_t> so that you don't need the `onAny` in the end.

NVM, i saw encoder still takes raw pointers:)


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54840/#review159619
-----------------------------------------------------------


On Dec. 17, 2016, 9:50 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54840/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2016, 9:50 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used process::loop to avoid stack overflow due to recursion.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/http.cpp 97d1424be20e217401519c2bee79857bcf087023 
> 
> Diff: https://reviews.apache.org/r/54840/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message