mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 54768: Libprocess: Reduced binary bloat due to 'mime'.
Date Mon, 19 Dec 2016 17:39:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54768/
-----------------------------------------------------------

(Updated Dec. 19, 2016, 5:39 p.m.)


Review request for mesos and Michael Park.


Changes
-------

Used initializer list.


Repository: mesos


Description
-------

Libprocess: Reduced binary bloat due to 'mime'.


Diffs (updated)
-----

  3rdparty/libprocess/Makefile.am 10f416387f3f5f9eeb7f8cc0f760299b1f1bfa82 
  3rdparty/libprocess/include/process/mime.hpp 2b8351a5c24670f8849f517903dcb60c0db3654f 
  3rdparty/libprocess/src/CMakeLists.txt a815a6b2360cbe0f244c090117ff948ef0db04ed 
  3rdparty/libprocess/src/mime.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/54768/diff/


Testing (updated)
-------

Using `nm --print-size --size-sort --radix=d -C src/.libs/libmesos.so`:
Original:
`22440 W process::mime::initialize()`
After patch:
`9076 T process::mime::initialize()`


Thanks,

Joris Van Remoortere


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message