mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 54838: Used process::io::BUFFERED_READ_SIZE instead of constant.
Date Sat, 17 Dec 2016 21:39:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54838/#review159557
-----------------------------------------------------------


Ship it!




Was this introduced recently or did I miss it the first time around when implementing this?
Should this be called "DEFAULT_BUFFERED_READ_SIZE"?

- Kevin Klues


On Dec. 17, 2016, 9:35 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54838/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2016, 9:35 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used process::io::BUFFERED_READ_SIZE instead of constant.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp c80627986f729255e3b3ad1fc9cfa6213e19c521

> 
> Diff: https://reviews.apache.org/r/54838/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message