mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay Guo <guojiannan1...@gmail.com>
Subject Re: Review Request 54830: Added helper function to get per-role resource allocations.
Date Sat, 17 Dec 2016 10:17:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54830/#review159545
-----------------------------------------------------------




src/common/resources.cpp (line 1081)
<https://reviews.apache.org/r/54830/#comment230570>

    I see we sometime use underscore as prefix and sometime suffix. I wonder if there's a
fixed rule for the style? Also, do we necessary need this underscore here?



src/common/resources.cpp (line 1084)
<https://reviews.apache.org/r/54830/#comment230572>

    Since `role` is `optional` in `allocationInfo`, do we need an explicit check for that
as well?



src/tests/resources_tests.cpp (lines 2756 - 2757)
<https://reviews.apache.org/r/54830/#comment230571>

    Maybe "Helper for creating an allocated resource, indicating resource that has been allocated
to a framework." ?


- Jay Guo


On Dec. 17, 2016, 12:28 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54830/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2016, 12:28 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jay Guo.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added helper function to get per-role resource allocations.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp f569c931ff7db8d51dfd7c96f4f2addab05df85d 
>   include/mesos/v1/resources.hpp f60ab794a0c7c24885c49cc47b798c363e3279e7 
>   src/common/resources.cpp 4bb9beffcb3509f4226b4985e05eccec01412d0f 
>   src/tests/resources_tests.cpp d6eb7787bac58c1133a4bab0fc17df49117fed87 
>   src/v1/resources.cpp 46cc00f2f453f5eb4ddc4b0b9b89be2bd89f05d9 
> 
> Diff: https://reviews.apache.org/r/54830/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> ```
> ./bin/mesos-tests.sh  --gtest_filter="AllocatedResourcesTest.Allocations" --verbose
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from AllocatedResourcesTest
> [ RUN      ] AllocatedResourcesTest.Allocations
> [       OK ] AllocatedResourcesTest.Allocations (0 ms)
> [----------] 1 test from AllocatedResourcesTest (0 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (17 ms total)
> [  PASSED  ] 1 test.
> ```
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message