mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 54770: Fixed the 'IOSwitchboardTest.KillSwitchboardContainerDestroyed' test.
Date Fri, 16 Dec 2016 18:11:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54770/#review159468
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/containerizer/io_switchboard_tests.cpp (line 639)
<https://reviews.apache.org/r/54770/#comment230472>

    You don't need this. Not setting ContainerInfo means using MesosContianerizer.


- Jie Yu


On Dec. 15, 2016, 2:03 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54770/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2016, 2:03 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-6784
>     https://issues.apache.org/jira/browse/MESOS-6784
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The container was launched with TTY enabled. This meant that
> killing the switchboard would trigger the task to terminate
> on its own owing to the "master" end of the TTY dying. This
> would make it not go through the code path of the isolator
> failing due to resource limit issue.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/io_switchboard_tests.cpp 5bd9dc4a776fe8a0d04ed31aa167f10c394984e6

> 
> Diff: https://reviews.apache.org/r/54770/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message