mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 54807: Windows: Disable CHECK-failing on symlink creation.
Date Fri, 16 Dec 2016 09:20:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54807/#review159421
-----------------------------------------------------------



Patch looks great!

Reviews applied: [54807]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 16, 2016, 6:43 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54807/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2016, 6:43 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Alex Clemmer, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This fixes the 500 or so tests that are enabled on Windows builds.
> 
> With the exception of some parts of the agent recovery pathway,
> creating symlinks is not necessary for the agent to function.
> The current set of tests will pass with or without the ability to
> create symlinks.  In the case of the ASF CI, we will never have the
> ability to create symlinks on Windows.
> 
> 
> Diffs
> -----
> 
>   src/slave/paths.cpp 8792cee43d94e7b0bbd7b80aebbe501236244621 
> 
> Diff: https://reviews.apache.org/r/54807/diff/
> 
> 
> Testing
> -------
> 
> .\support\windows-build.bat (Win10)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message