mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Review Request 54807: Windows: Disable CHECK-failing on symlink creation.
Date Fri, 16 Dec 2016 06:43:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54807/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer, Alex Clemmer, and Michael Park.


Repository: mesos


Description
-------

This fixes the 500 or so tests that are enabled on Windows builds.

With the exception of some parts of the agent recovery pathway,
creating symlinks is not necessary for the agent to function.
The current set of tests will pass with or without the ability to
create symlinks.  In the case of the ASF CI, we will never have the
ability to create symlinks on Windows.


Diffs
-----

  src/slave/paths.cpp 8792cee43d94e7b0bbd7b80aebbe501236244621 

Diff: https://reviews.apache.org/r/54807/diff/


Testing
-------

.\support\windows-build.bat (Win10)


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message