mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 54677: Windows: Enabled 495 passing tests on Agent builds.
Date Fri, 16 Dec 2016 01:24:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54677/
-----------------------------------------------------------

(Updated Dec. 16, 2016, 1:23 a.m.)


Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.


Changes
-------

Updating for changes in `api_tests.cpp`.


Bugs: MESOS-6698, MESOS-6699, MESOS-6703, MESOS-6705, MESOS-6706, MESOS-6707, MESOS-6709,
and MESOS-6715
    https://issues.apache.org/jira/browse/MESOS-6698
    https://issues.apache.org/jira/browse/MESOS-6699
    https://issues.apache.org/jira/browse/MESOS-6703
    https://issues.apache.org/jira/browse/MESOS-6705
    https://issues.apache.org/jira/browse/MESOS-6706
    https://issues.apache.org/jira/browse/MESOS-6707
    https://issues.apache.org/jira/browse/MESOS-6709
    https://issues.apache.org/jira/browse/MESOS-6715


Repository: mesos


Description
-------

This commit will introduce a sizeable chunk of the trivially-passing
Agent tests to the Windows build. Unlike #54618, which added test files
to the build only if they needed no modifications to compile and build
on Windows, here we add test files to the build only if they contain one
or more tests that either don't compile or don't pass. Hence, this
commit will partially address MESOS-6698, MESOS-6699, MESOS-6703,
MESOS-6705, MESOS-6706, MESOS-6707, MESOS-6709, and MESOS-6715.

In many of the files we added to the build, some of the tests either
don't compile, or don't pass. For tests that trivially compiled but
didn't pass, we use the `TEST_X_TEMP_DISABLED_ON_WINDOWS` macros. For
the tests that didn't compile, we simply `#ifdef` them out for now.


Diffs (updated)
-----

  src/tests/CMakeLists.txt 6aab5119336a1f149b9c8c0a4b7f5878e2a929be 
  src/tests/anonymous_tests.cpp bc29ff8be94af82dd97f43db4f9594036705e835 
  src/tests/api_tests.cpp 82c0fc27e5e707adb73faeb26828a2ce3e3feb16 
  src/tests/command_executor_tests.cpp f847f6a9f71270dd4b28b487b5f12bcfeb0d5fa6 
  src/tests/common/command_utils_tests.cpp afb1532aa114b0ee4752189a09c21ece24d7d27d 
  src/tests/credentials_tests.cpp 1ceb31b72446a87771705cab2255c264d8e00c08 
  src/tests/default_executor_tests.cpp d5a186ef24ca792640f25a280a2f081630fa3d43 
  src/tests/fault_tolerance_tests.cpp 71fe0df7c3997bea25431f7385e23d53456dd3cf 
  src/tests/fetcher_tests.cpp 8b8baf87127f430e91165b7cebc93ede697931bb 
  src/tests/files_tests.cpp f6a6aeaa4efa05957d1038c564157216fce70246 
  src/tests/gc_tests.cpp d9776b602bee780b9732cd93d06b9c8f3cc8a4d0 
  src/tests/health_check_tests.cpp 3b0125ee788f7193eef00f54ab6d63da472224b0 
  src/tests/hierarchical_allocator_tests.cpp cde32c9e7c7ac98d69f51c9f6ff89b4fae5cf595 
  src/tests/hook_tests.cpp 7956eaea4c8f8b0db33d0472764d00bdb4e6a80e 
  src/tests/master_allocator_tests.cpp 34e2b4950ad722a1b1470953053213b3db265eb4 
  src/tests/partition_tests.cpp 00cc815529dc4d303db638680eacb8f55713d1a1 
  src/tests/paths_tests.cpp 4def898c7eb0a3f5c5ffd858e9d3c9558cc49cce 
  src/tests/rate_limiting_tests.cpp 61674155bebea493ec60b277b72fdcf8f366e26b 
  src/tests/resource_offers_tests.cpp b6c15cb298ee49e18419b8ab7d17d6e95a2e1b8c 
  src/tests/role_tests.cpp 2ee7801bf9cbf68dce6305ac8872e00ed2476247 
  src/tests/scheduler_tests.cpp 95cad9ae8d9a8bd7f5e9ebd9f49cbc4e20ad596b 
  src/tests/slave_tests.cpp fc6b56c074c71b827a9ee522cd715c0d15ecc7e3 
  src/tests/status_update_manager_tests.cpp 38d8913a5b33aa5325d0bc632c0a1d80480eddf8 
  src/tests/uri_fetcher_tests.cpp 3c1bd33137612de90d65b7af288bb81ac9876c8b 

Diff: https://reviews.apache.org/r/54677/diff/


Testing
-------


Thanks,

Alex Clemmer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message