mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 54618: Windows: Added trivially passable tests to build.
Date Thu, 15 Dec 2016 22:15:51 GMT


> On Dec. 15, 2016, 2:06 p.m., Joseph Wu wrote:
> > src/tests/CMakeLists.txt, line 93
> > <https://reviews.apache.org/r/54618/diff/4/?file=1581392#file1581392line93>
> >
> >     Looks like all three of these ExceptionTests are aborting on Windows (Mesos
HEAD = 406e5f3700e179c50292b62912c2a94f9162b21b).  
> >     
> >     Glog does not print stack traces on Windows, but it appears to be a call to
`Result::get` where the Result is either None or Error.

Oops, nevermind.  I forget to apply this in the chain: https://reviews.apache.org/r/53706/


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54618/#review159375
-----------------------------------------------------------


On Dec. 10, 2016, 4:42 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54618/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2016, 4:42 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
> 
> 
> Bugs: MESOS-6700, MESOS-6704, MESOS-6710, MESOS-6711, and MESOS-6716
>     https://issues.apache.org/jira/browse/MESOS-6700
>     https://issues.apache.org/jira/browse/MESOS-6704
>     https://issues.apache.org/jira/browse/MESOS-6710
>     https://issues.apache.org/jira/browse/MESOS-6711
>     https://issues.apache.org/jira/browse/MESOS-6716
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit will resolve MESOS-6700, MESOS-6704, MESOS-6710, MESOS-6716,
> and MESOS-6711 by trivially adding the relevant test files to the
> Windows build.
> 
> 
> Diffs
> -----
> 
>   src/tests/CMakeLists.txt 0966b7f283ea2ce646a417e81b6dfe1134a7188c 
> 
> Diff: https://reviews.apache.org/r/54618/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message