mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Review Request 54769: Fixed a cleanup related bug in the IO switchboard.
Date Thu, 15 Dec 2016 02:03:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54769/
-----------------------------------------------------------

Review request for mesos, Jie Yu, Kevin Klues, and Vinod Kone.


Bugs: MESOS-6784
    https://issues.apache.org/jira/browse/MESOS-6784


Repository: mesos


Description
-------

Previously, we never used to wait for `reaped()` to be executed
completely before invoking `cleanup()`. This happened due to the
fact that `reaped()` returned a `void` making the overload of
`defer()` that just does `dispatch()` to the actor without
waiting for `reaped()` to be complete.


Diffs
-----

  src/slave/containerizer/mesos/io/switchboard.hpp 7a7ad2da047ef316f4382e45526d503c87a903a0

  src/slave/containerizer/mesos/io/switchboard.cpp c80627986f729255e3b3ad1fc9cfa6213e19c521


Diff: https://reviews.apache.org/r/54769/diff/


Testing
-------

make check (Fixed Test added later in the chain)


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message