mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 54768: Libprocess: Reduced binary bloat due to 'mime'.
Date Thu, 15 Dec 2016 01:48:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54768/#review159256
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/src/mime.cpp (line 152)
<https://reviews.apache.org/r/54768/#comment230206>

    Eh, let's do slightly better while we're at it.
    
    ```cpp
    types.insert({
      {".obj", "application/octet-stream"},
      {".ra", "audio/x-pn-realaudio"},
      ...
    });
    ```


- Michael Park


On Dec. 14, 2016, 5:33 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54768/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2016, 5:33 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Libprocess: Reduced binary bloat due to 'mime'.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am 10f416387f3f5f9eeb7f8cc0f760299b1f1bfa82 
>   3rdparty/libprocess/include/process/mime.hpp 2b8351a5c24670f8849f517903dcb60c0db3654f

>   3rdparty/libprocess/src/CMakeLists.txt a815a6b2360cbe0f244c090117ff948ef0db04ed 
>   3rdparty/libprocess/src/mime.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54768/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message