mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 54019: Modernized code to use `foreachpair` with LinkedHashMap.
Date Wed, 14 Dec 2016 22:50:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54019/
-----------------------------------------------------------

(Updated Dec. 14, 2016, 10:50 p.m.)


Review request for mesos and Michael Park.


Changes
-------

Rebase.


Bugs: MESOS-6626
    https://issues.apache.org/jira/browse/MESOS-6626


Repository: mesos


Description (updated)
-------

Various places were doing `foreach` over `LinkedHashMap::keys()` or
`LinkedHashMap::values()`; this can now be replaced with `foreachkey`
and `foreachvalue`, respectively.


Diffs (updated)
-----

  src/examples/long_lived_executor.cpp 5c43ee780997c105e4f3dd6081d4c5418bef7ab6 
  src/examples/test_http_executor.cpp b9b6bfdc55dead5b70d40b4389e65a2194babc0e 
  src/exec/exec.cpp 1dc20390907253a466b7272b7f8b33ea14afb236 
  src/hook/manager.cpp e9ca3860c1ab0e230db99f2b392358cde1e4a9c0 
  src/launcher/default_executor.cpp 6e377d41065a03d5c9ca794c0b998a233c52428b 
  src/launcher/executor.cpp cd5aa46df49b8cc352bf679a5cf2aac3d043f87d 
  src/master/master.cpp 8c1c7f94102a2f40fbdffaa36f2d1c15e78a906d 
  src/slave/http.cpp ecec24a0e9c608433738b804dde8887e4fd9f804 
  src/slave/slave.cpp 673f44b612d25d940abbfd1192ce6bd4d107689c 

Diff: https://reviews.apache.org/r/54019/diff/


Testing
-------

`make check`


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message