mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 54720: Added a test that verifies container attach after agent restart.
Date Wed, 14 Dec 2016 01:10:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54720/#review159085
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/containerizer/io_switchboard_tests.cpp (line 809)
<https://reviews.apache.org/r/54720/#comment230039>

    I think you need the new:
    ```
    #ifdef __linux__
      flags.agent_subsystems = None();
    #endif
    ```
    
    here.



src/tests/containerizer/io_switchboard_tests.cpp (line 886)
<https://reviews.apache.org/r/54720/#comment230040>

    Wait until slvae recovered? Your future is on `slave::Slave::_recover`


- Kevin Klues


On Dec. 13, 2016, 10:20 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54720/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2016, 10:20 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test that verifies container attach after agent restart.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/io_switchboard_tests.cpp 5bd9dc4a776fe8a0d04ed31aa167f10c394984e6

> 
> Diff: https://reviews.apache.org/r/54720/diff/
> 
> 
> Testing
> -------
> 
> make -j20 check GTEST_FILTER="*Switchboard*" MESOS_VERBOSE=1
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message