mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 51028: Fix tests with rapidly triggered allocations.
Date Tue, 13 Dec 2016 16:30:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51028/#review158967
-----------------------------------------------------------



I think this patch can also follow /r/51027/ in the chain.


src/tests/hierarchical_allocator_tests.cpp (lines 2796 - 2799)
<https://reviews.apache.org/r/51028/#comment229859>

    I think the following is sufficient. 
    
    ```
    Settle to make sure the dispatched allocation is executed.
    ```



src/tests/hierarchical_allocator_tests.cpp (lines 3003 - 3004)
<https://reviews.apache.org/r/51028/#comment229910>

    Similar to Guangya's suggestion, I think we can elaborate on the reason to use tow agents
and two frameworks.
    
    ```
    Trigger at least two allocation runs to generate the window statistics. Here we are using
two pairs of `addSlave()` and `addFramework()` calls because each guarantees one allocation
run that yields an `Allocation`.
    ```



src/tests/hierarchical_allocator_tests.cpp (line 3619)
<https://reviews.apache.org/r/51028/#comment229944>

    I think we are still intereted in the number of allocations and we expect to see them
decrease because of batching. We don't use EXPECT on them but we print them out as part of
the benchmark?


- Jiang Yan Xu


On Sept. 28, 2016, 2:16 p.m., Jacob Janco wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51028/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2016, 2:16 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3157
>     https://issues.apache.org/jira/browse/MESOS-3157
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> - Per MESOS-3157, if cluster events with the possibility
>   of triggering an allocation occur rapidly and test
>   assertions depend on gleaning information from assumed
>   order, it is likely they will fail due to lack of parity
>   between event and actual allocation. Ensure that expected
>   allocations occur.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp 46553f6d501deb37862dd5ba48be1c114f6e6cb8

> 
> Diff: https://reviews.apache.org/r/51028/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message