mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 53790: Move containerizer Rootfs support to a cpp file.
Date Tue, 13 Dec 2016 10:24:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53790/#review158980
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/containerizer/rootfs.cpp (lines 17 - 27)
<https://reviews.apache.org/r/53790/#comment229895>

    This double-includes `string`, `process/owned.hpp` and `stout/try.hpp` which are already
included in the header corresponding to this file. Not sure about the current dogmatics, but
my hunch would be to not do that.



src/tests/containerizer/rootfs.cpp (line 29)
<https://reviews.apache.org/r/53790/#comment229896>

    Please include this one before any other headers.


- Benjamin Bannier


On Nov. 29, 2016, 2:21 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53790/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2016, 2:21 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Kevin Klues, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6588
>     https://issues.apache.org/jira/browse/MESOS-6588
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Move containerizer Rootfs support to a cpp file.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 85eda538caf39f81f052896e744b7b0c724f81bb 
>   src/tests/CMakeLists.txt 23230123f96f35f2aca3676b0eaa835098ea4f79 
>   src/tests/containerizer/rootfs.hpp 6bc3835cbb62536ec933ef38c9e15138b8611e5f 
>   src/tests/containerizer/rootfs.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53790/diff/
> 
> 
> Testing
> -------
> 
> sudo make check (Fedora 24)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message