mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 54687: Moved `IOSwitchboard::requiresServer()` implementation to cpp.
Date Tue, 13 Dec 2016 01:14:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54687/#review158945
-----------------------------------------------------------


Ship it!




Ship It!

- Kevin Klues


On Dec. 13, 2016, 1:10 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54687/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2016, 1:10 a.m.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is consistent with all other methods of this class.
> No functional change.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/io/switchboard.hpp 9f4ce99d09d50b681e01b5d28fb5fc79e1ea85fc

>   src/slave/containerizer/mesos/io/switchboard.cpp f900924dd55c42966deb14c65fca380bebc86e2f

> 
> Diff: https://reviews.apache.org/r/54687/diff/
> 
> 
> Testing
> -------
> 
> make -j20 check GTEST_FILTER="*Switchboard*" MESOS_VERBOSE=1
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message