mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 54682: Fixed the tests by turning off agent subsystems in IOSwitchboard tests.
Date Tue, 13 Dec 2016 00:12:26 GMT


> On Dec. 13, 2016, 12:01 a.m., Kevin Klues wrote:
> > Should we add TODOs above all of these so we know to fix it once we add a proper
dependency check?

Yup, will add a TODO in the agent code.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54682/#review158931
-----------------------------------------------------------


On Dec. 12, 2016, 11:42 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54682/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2016, 11:42 p.m.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Agent subsystems should be not be used if the corresponding cgroups
> isolator is not used. Ideally, we should add a check in Mesos to
> disallow such a combination.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/io_switchboard_tests.cpp a1ac75549697ba13cbb7c38fcab4a724aefbb402

> 
> Diff: https://reviews.apache.org/r/54682/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message