mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 54681: Made some IOSwitchboardServer flags optional.
Date Tue, 13 Dec 2016 00:11:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54681/
-----------------------------------------------------------

(Updated Dec. 13, 2016, 12:11 a.m.)


Review request for mesos, Benjamin Bannier and Kevin Klues.


Changes
-------

Addressed Kevin's comments.


Summary (updated)
-----------------

Made some IOSwitchboardServer flags optional.


Repository: mesos


Description (updated)
-------

Although these flags are now optional, we actually require them to be
set when executing the mesos-io-switchbaord binary. We add a check to
make sure they are set properly.


Diffs (updated)
-----

  src/slave/containerizer/mesos/io/switchboard.hpp fb720f063396790a336170dcb4b103c844c8d2dc

  src/slave/containerizer/mesos/io/switchboard.cpp 210556f6ea60364a6332a07f294331b4d3457ff0

  src/slave/containerizer/mesos/io/switchboard_main.cpp 8c4b30aa1a09d3d59f0dd9e81989cd9f3eef89dd


Diff: https://reviews.apache.org/r/54681/diff/


Testing
-------

make check


Thanks,

Jie Yu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message