mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 54681: Used None() for some IOSwitchboardServer flags.
Date Tue, 13 Dec 2016 00:00:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54681/#review158927
-----------------------------------------------------------



I would reword the commit message to say:
```
Made some IOSwitchboardServer flags optional.

Although these flags are now optional, we actually require them to be set when executing the
mesos-io-switchbaord binary. We add a check to make sure they are set properly.
```


src/slave/containerizer/mesos/io/switchboard_main.cpp (line 76)
<https://reviews.apache.org/r/54681/#comment229768>

    Given these new semantics, I would probably print the whole usage string and list the
exact set of flags that were missing.
    
    As it is written now, it wouldn't be obvious that a flag was missing.


- Kevin Klues


On Dec. 12, 2016, 11:43 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54681/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2016, 11:43 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used None() for some IOSwitchboardServer flags.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/io/switchboard.hpp fb720f063396790a336170dcb4b103c844c8d2dc

>   src/slave/containerizer/mesos/io/switchboard.cpp 210556f6ea60364a6332a07f294331b4d3457ff0

>   src/slave/containerizer/mesos/io/switchboard_main.cpp 8c4b30aa1a09d3d59f0dd9e81989cd9f3eef89dd

> 
> Diff: https://reviews.apache.org/r/54681/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message