mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 54676: Fixed the environment overriding order in MesosContainerizer.
Date Mon, 12 Dec 2016 22:54:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54676/#review158911
-----------------------------------------------------------


Fix it, then Ship it!




LGTM modulo earlier comments from Avinash + a few other minor nits.


src/slave/containerizer/mesos/containerizer.cpp (line 1414)
<https://reviews.apache.org/r/54676/#comment229731>

    Missing Quotes before `CommandInfo`. Though, it seems there are other instances in this
file that don't seem to be doing so.



src/slave/containerizer/mesos/containerizer.cpp (line 1422)
<https://reviews.apache.org/r/54676/#comment229733>

    s/agent/the agent



src/tests/containerizer/cni_isolator_tests.cpp (line 527)
<https://reviews.apache.org/r/54676/#comment229737>

    s/that/that the



src/tests/containerizer/cni_isolator_tests.cpp (lines 578 - 581)
<https://reviews.apache.org/r/54676/#comment229736>

    How about just:
    
    ```cpp
    TaskInfo task = createTask(offer, command);
    ```


- Anand Mazumdar


On Dec. 12, 2016, 9:53 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54676/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2016, 9:53 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Avinash sridharan, Gilbert Song, and Qian Zhang.
> 
> 
> Bugs: MESOS-6781
>     https://issues.apache.org/jira/browse/MESOS-6781
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed the environment overriding order in MesosContainerizer.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp 747aaa840bcd9d94badad72964b506a8d43678f5

>   src/tests/containerizer/cni_isolator_tests.cpp b032c4345683813bca5f9a5eec09f73d860299cc

> 
> Diff: https://reviews.apache.org/r/54676/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message