mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 54589: Improved operator HTTP API docs.
Date Mon, 12 Dec 2016 22:18:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54589/#review158909
-----------------------------------------------------------



Thanks for the cleanup.


docs/endpoints/index.md (line 14)
<https://reviews.apache.org/r/54589/#comment229729>

    How about?
    
    ```
    If you are using Mesos 1.1 or later, it is highly recommended to consider using the new
[v1 Operator HTTP API](operator-http-api.md) instead of these unversioned REST endpoints (will
be deprecated in the future).
    
    ```



docs/operator-http-api.md (line 17)
<https://reviews.apache.org/r/54589/#comment229727>

    can you rebase on latest HEAD?
    
    "Accept-Type" should've been renamed to "Accept"



support/generate-endpoint-help.py (lines 228 - 231)
<https://reviews.apache.org/r/54589/#comment229730>

    see above.


- Vinod Kone


On Dec. 9, 2016, 5:17 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54589/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2016, 5:17 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix syntax errors, avoid use of "smart quotes" in protocol examples, and
> similar tweaks. Also mention Operator HTTP API in the old-style HTTP
> endpoints doc page.
> 
> 
> Diffs
> -----
> 
>   docs/endpoints/index.md e9f8b529d5a9e6cc4aef848675a6805a0ec721bc 
>   docs/operator-http-api.md 4f4c39e7b4b6de32af1933c34eba21f126fae8ac 
>   support/generate-endpoint-help.py 90431a729deaa1cb0a1006fa4a85787402c95c34 
> 
> Diff: https://reviews.apache.org/r/54589/diff/
> 
> 
> Testing
> -------
> 
> Reviewed output visually.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message