mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 52765: Populated `recovered_slaves` in `/state` and `/slaves` endpoints.
Date Mon, 12 Dec 2016 22:11:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52765/#review158902
-----------------------------------------------------------



Sorry for the delay on this.

As per our offline discussion, can you also make the `Summary<Slave>&` helper use
the new writer overload you added in a separate patch?


src/master/http.cpp (line 158)
<https://reviews.apache.org/r/52765/#comment229721>

    Any reason for not adding `port` here?



src/master/http.cpp (line 2309)
<https://reviews.apache.org/r/52765/#comment229722>

    Let's keep the same comment here as you have on L2688 later


- Anand Mazumdar


On Nov. 2, 2016, 4:42 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52765/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2016, 4:42 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Kunal Thakar.
> 
> 
> Bugs: MESOS-6177
>     https://issues.apache.org/jira/browse/MESOS-6177
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Populated `recovered_slaves` in `/state` and `/slaves` endpoints.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 2f275f6c78b92e13bd7d38043b581b5a3555ee40 
>   src/tests/master_tests.cpp ce42a106e8c671c9eaddb85d45153f31e0b9a488 
> 
> Diff: https://reviews.apache.org/r/52765/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message