mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay Guo <guojiannan1...@gmail.com>
Subject Re: Review Request 54650: Added validation for roles in ACCEPT call.
Date Mon, 12 Dec 2016 14:30:19 GMT


> On Dec. 12, 2016, 9:41 p.m., Qian Zhang wrote:
> > src/master/validation.cpp, line 1337
> > <https://reviews.apache.org/r/54650/diff/1/?file=1581654#file1581654line1337>
> >
> >     I would suggest to change to:
> >     ```
> >     return Error("Offer " + stringify(offerId) + " is no longer valid");
> >     ```

We tend to put caller available info in their own error message instead of callee's, see https://reviews.apache.org/r/54062/
for detailed explaination from BenM.


> On Dec. 12, 2016, 9:41 p.m., Qian Zhang wrote:
> > src/master/validation.cpp, lines 1425-1426
> > <https://reviews.apache.org/r/54650/diff/1/?file=1581654#file1581654line1425>
> >
> >     Suggest to change to:
> >     ```
> >     return Error("Offers for different roles in offer list);
> >     ```
> >     Similar with the error message in `validateUniqueOfferID()`.

Could you elaborate on the message?


- Jay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54650/#review158842
-----------------------------------------------------------


On Dec. 12, 2016, 4:42 p.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54650/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2016, 4:42 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Guangya Liu.
> 
> 
> Bugs: MESOS-6637
>     https://issues.apache.org/jira/browse/MESOS-6637
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> For a multi-role framework, it may receive offers for different roles
> in that framework. However, we disallow multiple offers with different
> roles being accepted in single ACCEPT call.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.cpp 96aa36585ded4bd7cf98526f710ccbc4f23b1f0f 
> 
> Diff: https://reviews.apache.org/r/54650/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message