mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 54637: Fixed EOF bug when tty is enabled in switch board server.
Date Sun, 11 Dec 2016 15:02:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54637/#review158799
-----------------------------------------------------------



Bad patch!

Reviews applied: [54637, 54620]

Failed command: ./support/apply-review.sh -n -r 54620

Error:
2016-12-11 15:01:21 URL:https://reviews.apache.org/r/54620/diff/raw/ [11532/11532] -> "54620.patch"
[1]
error: patch failed: src/tests/api_tests.cpp:4218
error: src/tests/api_tests.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/16411/console

- Mesos ReviewBot


On Dec. 11, 2016, 4:46 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54637/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2016, 4:46 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> stdin fd should only be closed when a tty is not attached.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp a354188a3656b5c2fd797b214f6c02714d70ce2c

> 
> Diff: https://reviews.apache.org/r/54637/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message